(#2738) Move setup module to install .Net 4.8 #2933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCakeIsNaOH
force-pushed
the
netfx-install
branch
from
cc7dc8a to
1c6f66b
Compare
8 tasks
gep13
reviewed
Dec 14, 2022
|
One thing to be aware of before merging this PR: Currently our Test Kitchen environment has Windows Server 2016 and 2019 without .Net 4.8. Both of these Operating Systems require a restart when installing .Net 4.8. This means that the converge step will fail until our Test Kitchen environment is updated. |
TheCakeIsNaOH
force-pushed
the
netfx-install
branch
from
1c6f66b to
36c2389
Compare
TheCakeIsNaOH
force-pushed
the
netfx-install
branch
from
36c2389 to
1312612
Compare
|
As I understand it, we need to get the AMI's used by Test Kitchen updated to have installed .NET 4.8. Let me pick this up and get it sorted. Moving this to draft in the meantime. |
TheCakeIsNaOH
force-pushed
the
netfx-install
branch
from
1312612 to
39e9a0a
Compare
|
As we have found out, the images being used already have .NET 4.8 installed on them, so we should be in a position to continue with this PR. |
This moves the setup module used during install and upgrade to check for and install .Net 4.8 instead of .Net 4.0 The timing of the check/install is moved to before the Chocolatey installation directory is created. This allows for re-running the install.ps1 script if a reboot is required without needing a manual cleanup of the partial installation. This also adds a check for the other reboot required exit code of 1641, and throws the install/upgrade if the installer requires a reboot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This moves the setup module used during install and upgrade to
check for and install .Net 4.8 instead of .Net 4.0
The timing of the check/install is moved to before the Chocolatey
installation directory is created. This allows for re-running the
install.ps1 script if a reboot is required without needing a manual
cleanup of the partial installation.
This also adds a check for the other reboot required exit code of
1641, and throws the install/upgrade if the installer requires
a reboot.
Motivation and Context
As Chocolatey CLI is being moved to .Net 4.8, it requires insuring that the required framework is installed.
Testing
Testing on Server 2012 R2:
Testing on clean Windows 7 SP1:
install.ps1script. It installed .net 4.8, did not require a reboot, and installed without issues. Local path to the nupkg specified by setting$env:ChocolateyDownloadUrlOperating Systems Testing
Change Types Made
Change Checklist
Related Issue
Part of #2738
https://app.clickup.com/t/20540031/PROJ-405